Add support for using Anthropic Claude models through Amazon Bedrock #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cohee1207
reviewed
Apr 8, 2024
| @@ -36,7 +36,9 @@ | |||
| "ws": "^8.13.0", | |||
| "yaml": "^2.3.4", | |||
| "yargs": "^17.7.1", | |||
| "yauzl": "^2.10.0" | |||
| "yauzl": "^2.10.0", | |||
| "@aws-sdk/client-bedrock-runtime": "^3.515.0", | |||
There was a problem hiding this comment.
Is this really necessary? We don't use official backend client packages but do direct HTTP calls instead.
There was a problem hiding this comment.
it isn't. bedrock has a rest api
There was a problem hiding this comment.
Yes, Bedrock do have a REST API, but I'd like to recommand using Bedrock SDK, cause:
- Bedrock has its own complicate authN mechanism(i.e. through SigV4),
- Customized wrapper over streaming data instead of SSE
There might be much more coding effort to do with REST API, thus offical SDK is a better choice.
Cohee1207
reviewed
Apr 10, 2024
Cohee1207
reviewed
Apr 10, 2024
Cohee1207
reviewed
Apr 10, 2024
Cohee1207
reviewed
Apr 10, 2024
added 5 commits
April 16, 2024 12:53
github-actions
bot
added
the
🚫 Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon Bedrock is a cloud service provided by AWS, it supports many Fundation Models, through this PR, user can use Anthropic's Claude models through Amazon Bedrock, in both streaming and non-streaming mode.