Fix for massive amounts of cards failing to load due to v8 engine limitations #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of chara cards to be loaded)
deffcolony
added
🟨 PR - Medium
🦋 Bug Fix
|
This pull request was automatically closed because it has been stalled for over 1 year with no activity. |
deffcolony
removed
⚰️ Stale
github-actions
bot
added
the
🚫 Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that has annoyed me and I've had it fixed in my build for a few months now so I might as well bring it over.
If you have too many cards or something, getCharacters() will completely fail because it's reading/loading all chara cards in one big chunk. This is a problem because the v8 engine has a maximum string limit, which I've exceeded.
So this PR introduces JSON streaming into getCharacters and the backend endpoint so chara cards can be loaded in smaller chunks and basically bypass this limit.