Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple images per expression #1776

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

Alyndiar
Copy link

@Alyndiar Alyndiar commented Feb 1, 2024

Adding support for multiple images per expression, with a random one selected each time if multiple are present

Adding support for multiple images per expression, with a random one selected each time if multiple are present
@Alyndiar Alyndiar changed the title Add files via upload Adding support for multiple images per expression Feb 2, 2024
As suggested, refactored so that only base expression and expression consisting of a base expression followed by a numerical suffixe are show in the interface and used as variants for automatic expression sprite selection
@Spacellary
Copy link
Contributor

Spacellary commented Feb 3, 2024

What does the naming or structure for these look like if say I'm importing an expression pack from .zip?

Would having "fear1.png" and "fear2.png" for example when importing from a file/folder work as expected?

I'm guessing yes from the regular expression ^${expression}(\\d*)$, as long as you follow the above naming scheme, but just making sure I'm understanding it.

@Alyndiar
Copy link
Author

Alyndiar commented Feb 5, 2024

What does the naming or structure for these look like if say I'm importing an expression pack from .zip?

Would having "fear1.png" and "fear2.png" for example when importing from a file/folder work as expected?

I'm guessing yes from the regular expression ^${expression}(\\d*)$, as long as you follow the above naming scheme, but just making sure I'm understanding it.

As far as I can tell, it will work exactly like that. I did not find anything in the import methods that would prevent it from working.

@Alyndiar
Copy link
Author

Alyndiar commented Feb 5, 2024

Please note I'm adding options to enable/disable the whole functionality. Give me a day or 2.

@Spacellary
Copy link
Contributor

@Alyndiar All good I was just wondering about it, take it easy and good work.

@Wolfsblvt
Copy link
Contributor

Any plans to continue this?

@Alyndiar
Copy link
Author

Alyndiar commented Mar 5, 2024 via email

@deffcolony deffcolony added ⚰️ Stale [ISSUE] [PR] No activity for over 1 month 🟩 PR - Small labels Mar 29, 2024
Copy link

This pull request was automatically closed because it has been stalled for over 1 year with no activity.

@github-actions github-actions bot closed this Apr 15, 2024
@deffcolony deffcolony removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month 🕸️ Inactive labels Apr 15, 2024
@deffcolony deffcolony reopened this Apr 15, 2024
@github-actions github-actions bot added the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 Merge Conflicts [PR] Submitted code needs rebasing 🟩 PR - Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants