GH-39: Prioritize command classes for interview #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Apr 7, 2024
First time we use COMMAND_CLASS_VERSION, query its own version supported. Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others. UAM rules can match unique device model, so we could override supported command class version attributes for matching device model. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
nkljajic
force-pushed
the
bugfix/GH-39-fix-prioritize-CC-for-interview
branch
from
714d5c6
to
15ef046
Compare
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Apr 24, 2024
…ritize-CC-for-interview
First time we use COMMAND_CLASS_VERSION, query its own version supported. Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others. UAM rules can match unique device model, so we could override supported command class version attributes for matching device model. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
nkljajic
force-pushed
the
bugfix/GH-39-fix-prioritize-CC-for-interview
branch
from
33b7883
to
6f120a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time we use COMMAND_CLASS_VERSION, query its own version supported.
Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others. UAM rules can match unique device model, so we could override supported command class version attributes for matching device model.