Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Bullet Sounds and a Sprite #2199

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

SierraHelper
Copy link
Collaborator

Оригинальный PR: Baystation12#34587

🆑BurpleBineapple
soundadd: Adds a minigun sound to the mounted and handheld miniguns. The sound is "Vulcan Machine Gun Series" from the YouTube Sound Library and part of Creative Commons (CC BY 4.0). Edited by me in Audacity to be a looping 0.5 second .ogg file.
tweak: Applies the gunshot_smg sound effect to the sec_smg.
tweak: Hivebots have had projectilesound added to some entries as the projectiles they were using no longer have their own sounds.
tweak: Moves most ballistic weapon sounds to the guns instead of them being weapon specific.
bugfix: Adds a missing neckbrace to the GCC operative hardsuit that now shows when active.
/🆑

In the process of adding a single minigun sound, this happened. Oh well.

Ballistic projectiles with the exception of the AMR have their sounds moved from the projectiles to the bullets. Currently, it's impossible to have unique weapon sounds due to the projectiles having their own firing sounds that take precedence. Instead, most of these sounds have been moved to the weapons allowing certain guns to sound different even if they use the same bullet. I didn't see a reason to do this with the laser weaponry due to the large number of laser guns that have different projectiles used during different firing modes. It makes more sense to leave them as they are.

The minigun now has a new sound effect. It's maybe not perfect but it's certainly better than the existing pistol pap. I also found an SMG sound effect that wasn't actually being used because of the projectile sound. It was already applied to the merc SMG but I went ahead and gave it to the sec SMG as well.

Also there was this neckbrace that apparently I missed when adding the GCC operative hardsuit so, that's in too now.
image

@SierraHelper SierraHelper requested a review from a team as a code owner May 7, 2024 07:56
@github-actions github-actions bot added ⛰️ Спрайты PR затрагивает спрайты 🔉 Звуки PR затрагивает звуки labels May 7, 2024
@SierraHelper SierraHelper added the 📜 CL валиден Ченджлог не содержит ошибок label May 7, 2024
@UEDCommander UEDCommander merged commit 8d31b76 into dev-sierra May 20, 2024
14 checks passed
@UEDCommander UEDCommander deleted the upstream-pr-34587 branch May 20, 2024 11:05
SierraHelper added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪞 MIR ЯОЯ ⛰️ Спрайты PR затрагивает спрайты 📜 CL валиден Ченджлог не содержит ошибок 🔉 Звуки PR затрагивает звуки
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants