Add ripper DSL #1820
Open
Add ripper DSL #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
reviewed
Mar 14, 2024
| it "generates RBI definitions for ripper state constants" do | ||
| rbi = rbi_for(:Ripper) | ||
|
|
||
| assert_match(/^Ripper::EXPR_BEG = \d+$/, rbi) |
There was a problem hiding this comment.
This actually generates Ripper::EXPR_BEG = T.let(T.unsafe(nil), ::Integer) so this match fails
vinistock
approved these changes
Mar 18, 2024
This doesn't quite fit in to the normal idea of a DSL, but I think it fits best here. Basically, because ripper isn't a normal gem and doesn't have a version, there's not a great way to generate static RBIs for it, because it depends on your current version of Ruby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This doesn't quite fit in to the normal idea of a DSL, but I think it fits best here. Basically, because ripper isn't a normal gem and doesn't have a version, there's not a great way to generate static RBIs for it, because it depends on your current version of Ruby.
If this doesn't belong here and can go elsewhere, let me know.
Implementation
Loop over the defined constants at runtime, generate the definitions.
Tests
I included tests.