Definition support for autoloaded constants

[Super-Xray]

Motivation

There are an issue calling for complete this function (#1893).

Implementation

autoload argument is a Prism::CallNode which has name :autoload. I create handle_autoload_definition method and add it to on_call_node_enter method in 'lib/ruby_lsp/listeners/definition.rb'. Then in handle_autoload_definition method, we can use the name of the constant in the Prism::SymbolNode under the Prism::CallNode and pass the name to find_in_index, which can create the response of jumping.

Automated Tests

Completed automated tests in test/requests/definition_expectations_test.rb, including test_jumping_to_autoload_definition_when_declaration_exists, test_jumping_to_autoload_definition_with_two_definition and test_does_nothing_when_autoload_declaration_does_not_exist

Manual Tests

1. Start the extension on this branch
2. open an .rb file which has autoload arguments.
3. move the cursor above the autoload arguments, press ctrl & click it
4. sometimes it doesn't work in original file of ruby-lsp since it's a sorbet project

[Super-Xray]

I have signed the CLA!

[Super-Xray]

I have signed the CLA!

[vinistock]

This is looking great! There's only one piece missing. To improve the precision of where you can cmd click, you need to add one extra check to this condition

target.name != :autoload

[vinistock]

This is already being checked where the method is invoked, so this can be removed.

[Super-Xray]

got it

[vinistock]

Suggested change

	arguments = node.arguments # should be 'ArgumentsNode'
	return unless arguments.is_a?(Prism::ArgumentsNode)
	symbol = arguments.arguments[0] # should be 'SymbolNode'
	return unless symbol.is_a?(Prism::SymbolNode)
	find_in_index(symbol.value)
	arguments = node.arguments&.arguments
	return unless arguments
	value = arguments.first&.value
	return unless value
	find_in_index(value)

[vinistock]

Multiple declarations for the same constant is already handled and tested by the index, so I'd remove this test.

[Super-Xray]

connected another email with the CLA

[Super-Xray]

I have signed the CLA!

[andyw8]

Needs a rebase, otherwise looks ready to go.

[andyw8]

Let's remove the blank line here.

[andyw8]

Once #2036 is solved, the tests can be updated so that the position corresponds to :Bar rather than autoload.

[andyw8]

There is one typecheck failure, it may indicate a missing nil check.

[Super-Xray]

There is one typecheck failure, it may indicate a missing nil check.

@andyw8 Did you mean this error？
I have fixed it.