Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual Ruby configuration #1967

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Apr 24, 2024

Motivation

Closes #1942

This is the final step to match the functionality in Shopify/vscode-ruby-lsp#923 and allow us to stabilize our prerelease version.

This PR allows users to manually select a Ruby installation both for specific workspaces or a global fallback in case they are not using a version manager.

Implementation

  1. If something fails during activation, we offer to either retry or manually configure Ruby
  2. In the manual configuration dialog, we allow setting either workspace or global Ruby path
  3. If a workspace path is set, we use that to launch Ruby
  4. If a global path is set, we use that as a fallback if regular activation fails

@vinistock vinistock added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Apr 24, 2024
@vinistock vinistock self-assigned this Apr 24, 2024
@vinistock vinistock requested a review from a team as a code owner April 24, 2024 20:37
@vinistock vinistock requested review from andyw8 and st0012 April 24, 2024 20:37
@vinistock vinistock force-pushed the vs/add_manual_ruby_selection branch from 425c7e6 to ce9cdf6 Compare May 1, 2024 20:29
@vinistock vinistock merged commit 96c5541 into main May 1, 2024
39 checks passed
@vinistock vinistock deleted the vs/add_manual_ruby_selection branch May 1, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you use this on windows? Or is this only for VSCode on Linux?
3 participants