Gh1940/alias support #1951
Open
Gh1940/alias support #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
nikijiandani
force-pushed
the
gh1940/alias-support
branch
from
20b01c9
to
0a55ab4
Compare
nikijiandani
added
the
server
nikijiandani
commented
May 1, 2024
| @@ -17,6 +17,7 @@ def index(source) | |||
|
|
|||
| def assert_entry(expected_name, type, expected_location) | |||
| entries = @index[expected_name] | |||
| refute_nil(entries, "Expected #{expected_name} to be indexed") | |||
There was a problem hiding this comment.
Introduced a refute_nil before we refute empty for better error messages
andyw8
reviewed
May 1, 2024
| assert_entry("whatever", Entry::UnresolvedMethodAlias, "/fake/path/foo.rb:1-8:1-16") | ||
| assert_entry("foo", Entry::UnresolvedMethodAlias, "/fake/path/foo.rb:2-15:2-19") | ||
| assert_entry("bar", Entry::UnresolvedMethodAlias, "/fake/path/foo.rb:3-15:3-20") | ||
| assert_equal(4, @index.instance_variable_get(:@entries).length) |
There was a problem hiding this comment.
May be worth a short explanation of where the 4 comes from.
| return unless new_name && old_name | ||
|
|
||
| new_name_value = case new_name | ||
| when Prism::StringNode |
There was a problem hiding this comment.
Would unescaped allow us to avoid this conditional?
ruby-lsp(main):028> Prism.parse("alias foo").value.statements.body.first.new_name.unescaped
=> "foo"
ruby-lsp(main):029> Prism.parse("alias :foo").value.statements.body.first.new_name.unescaped
=> "foo"
| old_name: String, | ||
| owner: T.nilable(Entry::Namespace), | ||
| file_path: String, | ||
| location: T.any(Prism::Location, RubyIndexer::Location), |
There was a problem hiding this comment.
Is RubyIndexer::Location needed here? It typechecks without it, so if we do need it we may be missing a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
first step for #1940
We need to keep track of aliases but they cannot be resolved until we know if the old method is inherited. Blocked on resolving aliases until #1333 is complete.
Implementation
Created new class for UnresolvedMethodAlias and started handling AliasNode and AliasMethod
Automated Tests
Added test in method_test