Move rubocop file watching into the server

[Earlopain]

Motivation

For #1457. Need to figure out how to clear old diagnostics after the config has been changed. Otherwise the user can see stale diagnostics.

Implementation

Automated Tests

Manual Tests

[vinistock]

To clear old diagnostics, you can just publish an empty array. We do this when files are closed

ruby-lsp/lib/ruby_lsp/server.rb

Line 278 in 9136779

send_message(

[Earlopain]

This isn't really working. Even though the notification is being pushed the diagnostics still remain. In fact, if I remove the call to textDocument/publishDiagnostics diagnostics still disappear when closing the file, so it looks like this isn't really doing anything.

My theory is that since diagnostics are pulled, the client isn't really interested in what the server has to say? Not coming up with much else.

[vinistock]

I wonder if this isn't a bug in the language server node package. There's no mention in the spec that pull diagnostics can't be cleared by a publish notification. And the documentation for publish explicitly mentions that pushing an empty array will clear previously existing diagnostics. It might be worth asking in https://github.com/microsoft/vscode-languageserver-node.

Another option, which might work (hopefully), is to collect diagnostics after re-creating the RuboCop instance and try to push the violations using the new configuration. Although, we may find ourselves in a similar situation if no diagnostics are collected after the configuration change.

[Earlopain]

I'll try to check that out sometime. Gonna dig around a bit beforehand. There are a few references to publishDiagnostics, I might find something