Remove Singleton from formatters
#1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it trivial to reload the rubocop config for Shopify#1457 without doing an awkward `Singleton.__init__`. With `GlobalState` being a thing now, I don't see the need for a singleton
andyw8
added
chore
vinistock
added
breaking-change
vinistock
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Nice. Thanks for the contribution!
We indeed don't need the singletons anymore and I'm happy to see them go.
Since the formatters are registered and kept in memory, we still achieve the same original goal (which was to avoid re-loading RuboCop configurations multiple times).
vinistock
added
other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will make it trivial to reload the rubocop config for #1457 without doing an awkward
Singleton.__init__.With
GlobalStatebeing a thing now, I don't see the need for a singleton anymore but open to hearing something else.Implementation
Just use
neweverywhere. This exposed an issue with theunload_rubocop_runnerfunction.RuboCopFormatterisn't defined ifRuboCopRunnerisn't defined, so both need to be removed fortest_shows_error_if_formatter_set_to_rubocop_but_rubocop_not_availableto properly workAutomated Tests
Existing ones
Manual Tests
Do some formatting, I guess.