Execute more specific test names for minitest specs #1609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will close #1605, do most of what is actually possible for #1604 and adress #1606 (comment)
Implementation
Use the group stack for spec as well. This removes most of the distinction these two previously had.
minitest_spec_halfwritten
simulates a user typing new specs. It mostly tests that the group ids being sent to vscode are well formed so something like in #1605 doesn't happen. It shows codelenses for everything which isn't entirely correct, but I think that's better than it shifting around during typing.I changed the reference marker into something that won't be escaped by shellescape. It needs to happen at the end, and when modified that doesn't work out.
Spec test names will look like this:
test_.*_my_test
, where.*
is the 0001 part. Having the actual numbers there would require keeping track of how manyit
s adescribe
block has encountered and might also just not be possible if there's something that defines tests outside ofit
because the numbers would then always be off.Automated Tests
Added something for the variations I could come up with.
Manual Tests
Tested code lenses for the modified/added expections execute the correct tests.