New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce .ruby-lsp.yml
config file
#1434
base: main
Are you sure you want to change the base?
Conversation
8aeeaa7
to
762cc52
Compare
762cc52
to
16480f7
Compare
098a109
to
ad1b277
Compare
ad1b277
to
2378bda
Compare
6e67b3d
to
e0b729e
Compare
lib/ruby_lsp/configuration.rb
Outdated
ruby_lsp_path = File.join(@workspace_uri.to_standardized_path, ".ruby-lsp.yml") | ||
|
||
if File.exist?(index_path) | ||
$stderr.puts("The .index.yml configuration file is deprecated. Please rename it to .ruby-lsp.yml and update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this should display a notification.
.ruby-lsp.yml
config file.ruby-lsp.yml
config file
(looks like some tests need a slightl adjustment for Windows) |
e0b729e
to
91fefb7
Compare
91fefb7
to
54aa985
Compare
I think the changes are good, but I wonder if having the configuration file isn't deviating from the LSP approach. We might be better off getting rid of the After #1818 is shipped, we could have the indexing configuration be a part of the global state and gather the configuration from the initialization options. I think it's worth ensuring we're following the LSP approach at this point, because otherwise we will have introduced two configuration files ( Thoughts? |
TODO: update |
Motivation
We want to have a general purpose configuration mechanism for Ruby LSP that not tied to a particular editor.
Also closes #1295 (but with a slightly different approach)
Implementation
As agreed with @vinistock, we will repurpose the current indexing configuration file,
.index.yml
.There will be a new top-level key,
indexing
, but within that the structure was the same as before.Automated Tests
Included
Manual Tests
.ruby-lsp.yml
and rename theindexing
key..index.yml
frommain
, and delete.ruby-lsp.yml
..index.yml
shows in the output panel..index.yml
and restart the LSP (so now there are no config files)