Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct configuration file from general index.yml in root of project with relocating it to already existing .ruby-lsp folder. #1295

Open
1 task done
ShPakvel opened this issue Jan 11, 2024 · 2 comments · May be fixed by #1434
Open
1 task done

Correct configuration file from general index.yml in root of project with relocating it to already existing .ruby-lsp folder. #1295

ShPakvel opened this issue Jan 11, 2024 · 2 comments · May be fixed by #1434
Assignees
@andyw8
Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale

Comments

@ShPakvel
Copy link

ShPakvel commented Jan 11, 2024 •
edited

I have checked that this feature is not already implemented

  • This feature does not exist

Use case

It should eliminate confusion and do not block general file name for specific purposes of projects.

Description

Currently configuration file .index.yml has too general name relative to root of a project and thus do not represent purpose properly. Described in this Readme chapter https://github.com/Shopify/ruby-lsp#configuring-code-indexing.

There is .ruby-lsp folder that is created in root of a project. I think this .index.yml file should be stored and read from that folder.

Implementation

No response
@ShPakvel ShPakvel added the enhancement New feature or request label Jan 11, 2024
@ShPakvel ShPakvel changed the title Correct configuration file from general index.yml to specific ruby-lsp name. Correct configuration file from general index.yml in root of project with relocating it to already existing .ruby-lsp folder. Jan 11, 2024
@andyw8 andyw8 self-assigned this Feb 29, 2024
@andyw8 andyw8 linked a pull request Feb 29, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Apr 30, 2024
@andyw8
Copy link
Contributor

andyw8 commented Apr 30, 2024

We're discussing if this is the right approach: #1434 (comment)

@vinistock vinistock added pinned This issue or pull request is pinned and won't be marked as stale and removed Stale labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyw8 andyw8

Labels
enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce .ruby-lsp.yml config file Shopify/ruby-lsp
3 participants
@andyw8 @ShPakvel @vinistock