Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a magnifying glass example #2419

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

rayronvictor
Copy link

Gravacao.de.Tela.2024-05-09.as.08.48.53.mp4

@rayronvictor
Copy link
Author

I have signed the CLA!

@wcandillon
Copy link
Collaborator

this is super cool thank you :)
I will review after app.js this week, hope it's ok 🙏

Copy link
Collaborator

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@wcandillon
Copy link
Collaborator

can you please fix the linting/tsc errors?
yarn lint --fix should do it. See: https://github.com/shopify/react-native-skia?tab=readme-ov-file#contributing

@wcandillon wcandillon self-requested a review June 4, 2024 07:40
Copy link
Collaborator

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayronvictor
Copy link
Author

can you please fix the linting/tsc errors? yarn lint --fix should do it. See: https://github.com/shopify/react-native-skia?tab=readme-ov-file#contributing

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants