Passing of props on WithSkiaWeb #2321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there was previously no good way to pass props directly into the component loaded by
WithSkiaWeb. This pull request adds a typedcomponentPropsfield that's forwarded to the result ofgetComponent. It matches the types of the corresponding component, and if there's any required fields,componentPropsitself is required. I believe this covers the full breadth of type-safety.This pull request does swap
WithSkiaPropsfrom being an interface to being a type. This shouldn't cause any issues, but if there's a strong preference for an interface here I can investigate other solutions.