Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visionos support #2286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

visionos support #2286

wants to merge 1 commit into from

Conversation

wcandillon
Copy link
Collaborator

@wcandillon wcandillon commented Mar 14, 2024

fixes #2280

@robertherber
Copy link

To get to the next step we also need to remove the dependency on UIScreen: https://github.com/robertherber/react-native-skia/pull/1/files#diff-b648d2a9fc3cd98b71316186a559b3e9e2396eeee45fc7cad6c04cdaf49ce3f5R36

After that this is what I see in XCode when building the react-native-visionos template project, which I guess is hinting at missing Skia framework for VisionOS?

Screenshot 2024-03-14 at 18 04 01

@okwasniewski
Copy link

okwasniewski commented Mar 21, 2024

Hey! I spent some time trying to make this work and I'm pretty sure that we should first adjust the configuration file to build skia for visionOS and then pack it up as an .xcframework together with iOS.

export const configurations: Configuration = {

Unfortunately, it looks like Google's gn (the build tool) doesn't support visionOS which might be a bigger issue https://gn.googlesource.com/gn/

@wcandillon wcandillon closed this Mar 27, 2024
@wcandillon wcandillon reopened this Mar 27, 2024
@wcandillon
Copy link
Collaborator Author

@okwasniewski as soon as Skia supports building it for visionOS we will definitely provide it part of the package.

@wcandillon
Copy link
Collaborator Author

@okwasniewski thanks for looking into this :)

@robertherber
Copy link

This issue might be interesting to track of, since Flutter will need to solve the same issues (unless they go Impeller-only for VisionOS).

Thanks @okwasniewski and @wcandillon for digging in this, looking forward to the possibilities with rn-skia on VisionOS will bring :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VisionOS Support
3 participants