New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Paragraph API (Rich Text) #1554
base: main
Are you sure you want to change the base?
Conversation
I believe this work was being referred to as the "paragraph API" in some other bugs/discussions. May I suggest including the name " paragraph" in the title for discoverability. I couldn't find it by searching and only stumbled on it when browsing. |
@siderakis done. To give an update on this feature. Step 1 is to expose the Skia Font Manager in React Native: #1662 |
Hi! @wcandillon! Is there any testing or additional development work that needs to be taken on to get this PR moving again? I'm happy to help with this one! |
@choudlet this is a great question. version 0.1.203 beta finally ships the paragraph module with Skia. Our plan is in the short term to offer a tokenizer to use with the paragraph module. This will enable what Skia calls "Client unicode": https://github.com/google/skia/blob/main/modules/skparagraph/src/ParagraphBuilderImpl.h#L63 From there, we would be in a state where you would be able to extend the JSI API the same way we look at it for the Animated GIF API. It's just that API is large but the complexity is low. From there, we would be able to add the declarative API for the paragraph module as seen in this PR. |
@wcandillon ok awesome! Yes I see all of the method stubs that you created in that PR that we would need to go ahead and implement. Happy to jump on that and help once the PR is in and stable! |
No description provided.