Return early in GraphQL fill for primitive partial #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
Flufd
force-pushed
the
graphql-fixtures/optimise-fill
branch
from
3b82927
to
656eade
Compare
|
/snapit |
|
🫰✨ Thanks @Flufd! Your snapshot has been published to npm. Test the snapshot by updating your yarn add graphql-fixtures@4.0.1 |
Flufd
commented
Dec 7, 2023
| })), | ||
| }); | ||
|
|
||
| expect(spy.mock.calls.length).toBeLessThan(100); |
There was a problem hiding this comment.
Without this change, the seed is reset 8000+ times, with the change it is ~60
mattkubej
approved these changes
Dec 7, 2023
Flufd
force-pushed
the
graphql-fixtures/optimise-fill
branch
from
656eade
to
75b01ee
Compare
Flufd
force-pushed
the
graphql-fixtures/optimise-fill
branch
from
75b01ee
to
43ec02d
Compare
znja
approved these changes
Dec 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimises the GraphQL filler by returning early in the
createValuefunction if we have a concrete partial value.I was profiling some slower tests in admin and found that a lot of the time was spent calling faker's
seedmethod. This is done with a stable seed for the particular branch/leaf node on the GraphQL document so that the random values for each node are stable. The re-seeding of the faker instance is slow, because it needs to reinitialise the mersenne twister that is used for RNG.For large lists of known primitive values, such as currency or country codes, or other arrays of enums, which in the admin might be 200+ elements long for country codes, this becomes a performance issue. We are reseeding the faker instance for each element, even when not consuming it.
Another optimisation and some thoughts on random data in general:
#2700