Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric string fields #2643

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Apr 30, 2023

  1. quilt,quilt/react-form: Add support for numeric string fields in form…

    … state
    
    1. Update the form state comparison by converting numeric string fields to numbers, enabling correct dirty state evaluation
    2. Add isNumericString utility function to identify numeric strings and exclude empty strings
    
    Fixes: Shopify#2629
    jayanth-kumar-morem committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    6d46557 View commit details
    Browse the repository at this point in the history
  2. quilt,quilt/react-form: Add isNumericString() tests

    1. Add tests to ensure isNumericString() returns true for valid numeric strings
    2. Add tests to ensure isNumericString() returns false for non-numeric strings
    3. Add tests to ensure isNumericString() returns false for non-string values
    
    Fixes: Shopify#2629
    jayanth-kumar-morem committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    a5a8b00 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Configuration menu
    Copy the full SHA
    e34f2dc View commit details
    Browse the repository at this point in the history