Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLS to performance & koa-performance #2576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CLS to performance & koa-performance #2576

wants to merge 1 commit into from

Conversation

mklocke-shopify
Copy link

@mklocke-shopify mklocke-shopify commented Feb 22, 2023 •
edited

Description

This is a (perhaps naive) attempt to add cumulative layout shift to the performance and koa-performance packages.

Only did a patch bump as this shouldn't be a breaking change, the new metric should be included seamlessly for any consumers that choose to upgrade to this version.

Fixes (issue #)
https://github.com/Shopify/opentelemetry-js/issues/156

@mklocke-shopify mklocke-shopify changed the title Mklocke/add cls to performance Add CLS to performance & koa-performance Feb 22, 2023
@mklocke-shopify mklocke-shopify marked this pull request as ready for review February 22, 2023 22:38
@mklocke-shopify mklocke-shopify requested a review from a team as a code owner February 22, 2023 22:38
@lucabezerra lucabezerra removed their request for review March 1, 2023 16:34
@mklocke-shopify
Copy link
Author

Sorry for the delay on this folks, I know its getting stale. I'll get to this again this week I hope.

@lucabezerra
Copy link
Contributor

Do we care about commit organization in quilt? Wondering if it'd be valid to squash the commits into a single one before merging.

@lucabezerra
Copy link
Contributor

Is this PR moving forward or should we close it? I was hoping to stop getting daily notifications from it 😅

@mklocke-shopify
Copy link
Author

Is this PR moving forward or should we close it? I was hoping to stop getting daily notifications from it 😅

Ahh I'm sorry about that! This is on me, if I don't have it in a good state in a day or two I'll close it. Sorry for the spam!

@mklocke-shopify mklocke-shopify force-pushed the mklocke/add-cls-to-performance branch from 3f30837 to a096449 Compare May 3, 2023 15:26
@mklocke-shopify
Copy link
Author

I've squashed the commits and updated the readme. This is ready for review now.

If you have a few minutes @ryanwilsonperkin @lucabezerra please have another look and let me know if it looks okay, thanks!

lucabezerra
lucabezerra approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@lucabezerra lucabezerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for circling back to this!

From my end it looks ok, but since @ryanwilsonperkin flagged the issue, let's wait for him to say something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbzodek gbzodek gbzodek left review comments

@ryanwilsonperkin ryanwilsonperkin ryanwilsonperkin approved these changes

@lucabezerra lucabezerra lucabezerra approved these changes

@emileber emileber Awaiting requested review from emileber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mklocke-shopify @lucabezerra @ryanwilsonperkin @gbzodek