[react-form] Remove useMountedRef check in useSubmit
#2514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jokull, are you able to produce a test case that fails without this change but passes with the change? I am wary of merging this change without proof that it fixes an issue and doesn't produce regressions in react 17. |
|
@jokull just wondering if this is still something you are willing to do. If you can share a test case to reproduce this it will be great. Thanks! |
|
Hi team! I've spent some time on this today. After upgrading to Next 13.2 none of these bugs are happening anymore. There must have been some weird compilation going on or something. I suggest upgrading to Next 13.2 for anyone running onto these bugs. Feel free to close those two mentioned. |
|
strict mode is breaking it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2500 and #2508 - maybe more things related to
useSubmitI believe the early exit inside
submitis being triggered unwantingly in Next.js environments. This is a fix for that, but I'm not sure if it is then a regression for other scenarios.