Removing and from the useQuery type

Shopify · May 2, 2023 · d00962d · d00962d
1 parent 42b7dd3
commit d00962d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/breezy-dolphins-exercise.md b/.changeset/breezy-dolphins-exercise.md
@@ -0,0 +1,7 @@
+---
+'@shopify/react-graphql': patch
+---
+
+Fixing an issue with useQuery / Query types
+
+`onCompleted` and `onError` callback are not supported by our custom implementation and should be exclude from the types
diff --git a/packages/react-graphql/src/hooks/types.ts b/packages/react-graphql/src/hooks/types.ts
@@ -13,7 +13,12 @@ import type {VariableOptions} from '../types';
 
 export type QueryHookOptions<Data = any, Variables = OperationVariables> = Omit<
   QueryComponentOptions<Data, Variables>,
-  'query' | 'partialRefetch' | 'children' | 'variables'
+  | 'query'
+  | 'partialRefetch'
+  | 'children'
+  | 'variables'
+  | 'onCompleted'
+  | 'onError'
 > &
   VariableOptions<Variables> & {
     skip?: boolean;