Removing onCompleted and onError from the useQuery

Shopify · Jun 27, 2023 · 20789f2 · 20789f2
1 parent 74eb82a
commit 20789f2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/breezy-dolphins-exercise.md b/.changeset/breezy-dolphins-exercise.md
@@ -0,0 +1,5 @@
+---
+'@shopify/react-graphql': patch
+---
+
+Remove `onCompleted` and `onError` from the types on `useQuery`'s options as they are not implemented
diff --git a/packages/react-graphql/src/hooks/types.ts b/packages/react-graphql/src/hooks/types.ts
@@ -13,7 +13,12 @@ import type {VariableOptions} from '../types';
 
 export type QueryHookOptions<Data = any, Variables = OperationVariables> = Omit<
   QueryComponentOptions<Data, Variables>,
-  'query' | 'partialRefetch' | 'children' | 'variables'
+  | 'query'
+  | 'partialRefetch'
+  | 'children'
+  | 'variables'
+  | 'onCompleted'
+  | 'onError'
 > &
   VariableOptions<Variables> & {
     skip?: boolean;