Update Card and LegacyCard mobile styles
#11926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyjoethomas Just wanted to double check from a design standpoint that we always want to remove shadow styles when |
lgriffee
force-pushed
the
card-mobile-alignment
branch
2 times, most recently
from
288afa0
to
5410382
Compare
Correct. |
sam-b-rose
reviewed
Apr 23, 2024
|
Looks good 馃憤 Would LegacyCard be updated in a separate PR? |
lgriffee
force-pushed
the
card-mobile-alignment
branch
from
5410382
to
41e2eb1
Compare
lgriffee
changed the title
Card mobile stylesCard and LegacyCard mobile styles
lgriffee
changed the title
Card and LegacyCard mobile stylesCard and LegacyCard mobile styles
jesstelford
approved these changes
May 9, 2024
|
Closing in favor of build phase PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes https://github.com/Shopify/polaris-internal/issues/1559
Closes https://github.com/Shopify/mobile/issues/33783
WHAT is this pull request doing?
Removes
CardandLegacyCarddefault bevel styles below thesmbreakpoint. Essentially if card corners aren鈥檛 rounded then shadow styles are removed as well.Currently the
Cardcomponent togglesborder-radiusat certain breakpoints with theroundedAboveprop (and defaults to thesmbreakpoint). This PR also addsbox-shadowto these toggled styles.smbreakpoint)smbreakpoint)How to 馃帺
CardStorybook BeforeCardStorybook AfterLegacyCardStorybook BeforeLegacyCardStorybook After