Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Changed Buttons mobile font size and spacing for primary and secondary variants #11899

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davebcn87
Copy link

@davebcn87 davebcn87 commented Apr 17, 2024

WHY are these changes introduced?

Fixes #0000

#33429
#33551

WHAT is this pull request doing?

Changes on ButtonGroup and PageActions
Screenshot 2024-04-29 at 5 23 32 PM
Screenshot 2024-04-29 at 5 23 23 PM
Screenshot 2024-04-29 at 5 23 10 PM
Screenshot 2024-04-29 at 5 23 00 PM
Screenshot 2024-04-29 at 5 22 50 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@davebcn87 davebcn87 changed the title [Prototype Mobile] Changed font size and spacing for primary and secondary buttons [Prototype] Changed Buttons mobile font size and spacing for primary and secondary variants Apr 17, 2024
@davebcn87
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @davebcn87! Your snapshothas been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240417135446"

@ssetem ssetem mentioned this pull request Apr 17, 2024
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@davebcn87 davebcn87 force-pushed the mobile/button-styles branch 2 times, most recently from b10ff55 to cd11a8e Compare April 23, 2024 11:58
@github-actions github-actions bot removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 23, 2024
@davebcn87
Copy link
Author

/snapit

Copy link
Contributor

🫰✨ Thanks @davebcn87! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-icons": "0.0.0-snapshot-20240423120015",
"@shopify/polaris-migrator": "0.0.0-snapshot-20240423120015",
"@shopify/polaris": "0.0.0-snapshot-20240423120015",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240423120015",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240423120015"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants