Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChoiceList mobile styles #11896

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Apr 16, 2024

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1590
Fixes https://github.com/Shopify/mobile/issues/33785

Caution

Basing this PR off of #11837 and will not merge until that ships. No need to include changes from #11878 since the helper/error text changes do not factor into clickable area.

WHAT is this pull request doing?

  • Increases Choice padding so the tap target on mobile is 48px
  • Improves ChoiceList mobile padding
Before After
Screenshot 2024-05-06 at 3 26 43 PM Screenshot 2024-05-06 at 3 26 38 PM
Screenshot 2024-05-06 at 3 28 03 PM Screenshot 2024-05-06 at 3 28 10 PM

How to 🎩

Tip

Make sure you have the breakpoint in storybook at sm or xs to see the changes!

@lgriffee lgriffee added the #gsd:40396 WebView infrastructure - Forms and Polaris label Apr 16, 2024
@lgriffee lgriffee self-assigned this Apr 16, 2024
@lgriffee
Copy link
Member Author

/snapit

Copy link
Contributor

🫰✨ Thanks @lgriffee! Your snapshothas been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240416230446"

@ssetem ssetem force-pushed the choicelist-mobile-alignment branch from 97475fd to d96cdb0 Compare April 17, 2024 08:20
@ssetem ssetem mentioned this pull request Apr 17, 2024
@ssetem ssetem force-pushed the choicelist-mobile-alignment branch from d96cdb0 to 243caa8 Compare April 17, 2024 09:19
@lgriffee lgriffee force-pushed the choicelist-mobile-alignment branch 2 times, most recently from 97475fd to fab4bbd Compare April 19, 2024 17:57
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@lgriffee lgriffee changed the base branch from main to revert-11833-revert-11724-theme-to-responsive May 6, 2024 17:52
@lgriffee lgriffee force-pushed the choicelist-mobile-alignment branch from 6af762a to 0ac65ae Compare May 6, 2024 18:05
@github-actions github-actions bot removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label May 6, 2024
@lgriffee lgriffee changed the title [Prototype] Update ChoiceList mobile styles Update ChoiceList mobile styles May 6, 2024
@lgriffee lgriffee requested a review from aveline May 6, 2024 18:25
@lgriffee lgriffee marked this pull request as ready for review May 6, 2024 18:25
@lgriffee lgriffee force-pushed the choicelist-mobile-alignment branch from 0ac65ae to f07e1b0 Compare May 6, 2024 18:29
Copy link
Contributor

@aveline aveline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just one question about the indentation of the children content, I noticed it's updated to now be in line with the radio button, is that intentional? I didn't see an example in the Figma.

@lgriffee
Copy link
Member Author

lgriffee commented May 6, 2024

Looks good overall! Just one question about the indentation of the children content, I noticed it's updated to now be in line with the radio button, is that intentional? I didn't see an example in the Figma.

@aveline Yes, it was an intentional change based on these mockups in Figma. Would be good to confirm with @heyjoethomas this is still the desired design update!

@lgriffee lgriffee changed the base branch from revert-11833-revert-11724-theme-to-responsive to main May 8, 2024 21:58
@lgriffee lgriffee changed the base branch from main to revert-11833-revert-11724-theme-to-responsive May 8, 2024 22:02
@lgriffee lgriffee closed this May 9, 2024
@lgriffee
Copy link
Member Author

lgriffee commented May 9, 2024

Closing in favor of build phase PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:40396 WebView infrastructure - Forms and Polaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants