Change Banner layout to better align with mobile #11887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciomeirelles
changed the title
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
from
ef65185
to
bb935f6
Compare
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
2 times, most recently
from
3f43430
to
0432570
Compare
|
/snapit |
|
🫰✨ Thanks @mauriciomeirelles! Your snapshothas been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240412151826" |
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
2 times, most recently
from
7be79f2
to
c2ad416
Compare
mauriciomeirelles
requested review from
davebcn87,
ssetem,
kyledurand,
sam-b-rose,
nandinicbit1981 and
lgriffee
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
from
c2ad416
to
c6ff816
Compare
kyledurand
approved these changes
Apr 12, 2024
| '@shopify/polaris': patch | ||
| --- | ||
|
|
||
| Add border to Banner on breakpoint-xs and change success icon to CheckCircleIcon |
There was a problem hiding this comment.
Suggested change
| Add border to Banner on breakpoint-xs and change success icon to CheckCircleIcon | |
| Added border to Banner on breakpoint-xs and change success icon to CheckCircleIcon |
| @@ -3,6 +3,12 @@ | |||
| position: relative; | |||
| display: flex; | |||
|
|
|||
| margin-inline: var(--p-space-300); | |||
There was a problem hiding this comment.
Do we still have to support old mobile safari versions? I thought logical properties were still out because of that. Not a blocker at all. I'm all for using them since it's not task blocking for the long tail
|
/snapit |
|
🫰✨ Thanks @mauriciomeirelles! Your snapshothas been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240415094702" |
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
2 times, most recently
from
7aca883
to
5c36a7b
Compare
heyjoethomas
requested changes
Apr 16, 2024
aaronccasanova
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
from
5c36a7b
to
a299eb3
Compare
github-actions
bot
added
the
cla-needed
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
from
a299eb3
to
15930a6
Compare
mauriciomeirelles
force-pushed
the
mmeirelles/change_banner_border_radius_sm
branch
from
15930a6
to
bf15e36
Compare
github-actions
bot
removed
the
cla-needed
mauriciomeirelles
changed the title
|
/snapit |
|
🫰✨ Thanks @mauriciomeirelles! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240429113201",
"@shopify/polaris": "0.0.0-snapshot-20240429113201",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240429113201",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240429113201" |
|
Closing in favor of #11959 to only apply changes below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/mobile/issues/33410
WHAT is this pull request doing?
Implement design from https://www.figma.com/file/PQUFqE9VrOtVPZbaifdL5J/Forms?type=design&node-id=2241-9876&mode=design&t=IEI19PTpbkZdyhKO-0
Also changes the
successicon fromCheckIcontoCheckCircleIconHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes