Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Align TextField styles with mobile #11859

Closed
wants to merge 3 commits into from

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Apr 8, 2024

Warning

This PR is not intended to be merged! This is only for exploratory prototyping.

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1564

WHAT is this pull request doing?

Creates a new storybook for exploring mobile style alignment.

@lgriffee lgriffee added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Apr 8, 2024
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

@ssetem ssetem force-pushed the textfield-mobile-alignment branch from 83ba391 to 72d476d Compare April 9, 2024 11:42
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

@ssetem ssetem force-pushed the textfield-mobile-alignment branch from 72d476d to c9aebf9 Compare April 9, 2024 11:57
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

@ssetem ssetem force-pushed the textfield-mobile-alignment branch from c9aebf9 to 79ce7f3 Compare April 9, 2024 11:59
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

1 similar comment
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

@ssetem ssetem force-pushed the textfield-mobile-alignment branch 2 times, most recently from c2d91af to 4bd42e9 Compare April 9, 2024 12:26
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 9, 2024

🫰✨ Thanks @ssetem! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240409123018"

@ssetem ssetem force-pushed the textfield-mobile-alignment branch from 4bd42e9 to 0d8c1b8 Compare April 9, 2024 14:00
@ssetem
Copy link
Contributor

ssetem commented Apr 9, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 9, 2024

🫰✨ Thanks @ssetem! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240409152616"

@lgriffee lgriffee removed the 🤖Skip Changelog Causes CI to ignore changelog update check. label Apr 9, 2024
@ssetem ssetem force-pushed the textfield-mobile-alignment branch from 0d8c1b8 to 3108c84 Compare April 10, 2024 10:42
@ssetem
Copy link
Contributor

ssetem commented Apr 10, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @ssetem! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240410104400"

@lgriffee lgriffee changed the title [TextField] Mobile alignment explorations [Prototype] Align TextField styles with mobile Apr 11, 2024
@lgriffee lgriffee mentioned this pull request Apr 11, 2024
@lgriffee
Copy link
Member Author

Closing in favor of #11876

@lgriffee lgriffee closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants