Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv 3.3.0 as an explicit gemspec dependency to support Ruby 3.4.0 default gems changes. #1014

Merged
merged 3 commits into from May 14, 2024

Conversation

tvongaza
Copy link
Contributor

@tvongaza tvongaza commented May 1, 2024

I get the following warning in our apps tests suite which makes use of the maintenance_tasks gem when run against Ruby 3.3.1:

~/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/bootsnap-1.18.3/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30: warning: ~/.rbenv/versions/3.3.1/lib/ruby/3.3.0/csv.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec.

Ruby 3.3.0 adds a warning about Gems which will no longer be part of the default gems in Ruby 3.4.0. Details are here: https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

Standard library updates
RubyGems and Bundler warn if users do require the following gems without adding them to Gemfile or gemspec. This is because they will become the bundled gems in the future version of Ruby.

Targeted libraries are:

  • csv

This PR adds csv to the gemspec to make it compatible with 3.4.0 when it is released.

Copy link
Member

@etiennebarrie etiennebarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to approve the CLA too.

maintenance_tasks.gemspec Outdated Show resolved Hide resolved
Remove version requirement on the csv dependency.

Co-authored-by: Étienne Barrié <etienne.barrie@gmail.com>
@tvongaza
Copy link
Contributor Author

tvongaza commented May 7, 2024

I have signed the CLA!

Gemfile.lock Outdated Show resolved Hide resolved
@etiennebarrie etiennebarrie merged commit 391fe95 into Shopify:main May 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants