Analytics feedbacks #2025
Analytics feedbacks #2025
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
|
Fixes #0000 👯 |
This comment has been minimized.
This comment has been minimized.
| return window.Shopify.customerPrivacy.analyticsProcessingAllowed(); | ||
| } | ||
| return false; | ||
| } catch (error) { |
There was a problem hiding this comment.
Nit picky, but worth printing the error? Or maybe just killing the param altogether?
There was a problem hiding this comment.
ts doesn't like catch() {}. End with catch(e) {}
| typeof window?.Shopify?.customerPrivacy?.analyticsProcessingAllowed === | ||
| 'function' | ||
| ) { |
There was a problem hiding this comment.
Nit picky, but could this whole if statement just be typeof window?.Shopify?.customerPrivacy?.analyticsProcessingAllowed === 'function'? If any property along the way is undefined, typeof undefined will not be function.
There was a problem hiding this comment.
good call .. in fact, since the whole thing is in a try-catch, the if statement is not needed
The try catch is needed because this function may be run at server side
WHY are these changes introduced?
<Analytics.Provider>will not send any events.consent.checkoutDomainandconsent.storefrontAccessTokenis requiredIntroduce
onReadycallback foruseCustomerPrivacyhook.WHAT is this pull request doing?
HOW to test your changes?
Use
analyticsexample:consent.checkoutDomainfrom root loader --> site should generate error about missing propsconsent.storefrontAccessTokenfrom root loader --> site should generate error about missing propsconsent.withPrivacybanner: falsein the root loader --> You should seeCustomAnalyticslogging page views in the console logPost-merge steps
Checklist