Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs #1759

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sergejasadchij
Copy link

WHAT is this pull request doing?

This adds the usual breadcrumbs functionality common to e-commerce

WHAT is this pull request doing?

Adds Breadcrumbs to pages.

There are different view of the breadcrumbs on mobile and decktop screens.
изображение

изображение

By default bredcrumbs on HomePage is hidden, but it is posiible to show it.

HOW to test your changes?

  • Go to any page other than the HomePage
  • Click on different parts of the Breadcrumbs
  • Check it on mobile and desktop screens

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@blittle
Copy link
Contributor

blittle commented Feb 14, 2024

@mynameisadamf what do you think about this UX improvement?

@mynameisadamf
Copy link

@blittle How are these breadcrumbs being populated? We did present the idea of adding breadcrumbs prior, following the OS solution, but was manual. If dynamically populated referencing the collection, what happens when the product is assigned to more than one collection?

@juanpprieto
Copy link
Contributor

How are these breadcrumbs being populated? We did present the idea of adding breadcrumbs prior, following the OS solution, but was manual. If dynamically populated referencing the collection, what happens when the product is assigned to more than one collection?

@mynameisadamf They are just following the URL Home | collections | collection-handle. There is no nested collections. It's just a basic one-level breadcrumps navigation

@mynameisadamf
Copy link

mynameisadamf commented Mar 12, 2024

@juanpprieto

They are just following the URL Home | collections | collection-handle

It's just a basic one-level breadcrumbs navigation

But if a merchant can assign a product to many collections. Which collection-handle would display in the breadcrumb?

I'm just making sure we're demoing the right solution for a real-world scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants