add keyboard navigation support to Listbox #1726
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
These changes are introduced to improve accessibility and UX for the product options Listbox.
WHAT is this pull request doing?
Link
andonClick
handler, in favour of the Listbox'sonChange
handler, providing native support for keyboard navigation.closeRef
and manages the Listbox state withuseState
, allowing selected option in the Listbox button to update immediately rather than after the route change has occurred. Maybe this should instead be handled optimistically but I am not sure..If there is anything that you'd like to see done differently, please let me know and I will update the change accordingly.
HOW to test your changes?
/products/snowboard
).Checklist