Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change brand @type to Brand in ProductSeo #2131

Open
wants to merge 2 commits into
base: v1.x-2022-07
Choose a base branch
from
Open

Change brand @type to Brand in ProductSeo #2131

wants to merge 2 commits into from

Conversation

mperreux
Copy link
Contributor

@mperreux mperreux commented Sep 13, 2022 •
edited

Description

The @type field on the ProductSeo brand field is incorrect. It should be Brand instead of Thing.
Motivation:
Screen Shot 2022-09-13 at 7 05 39 PM

Additional context

Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@mperreux mperreux marked this pull request as ready for review September 13, 2022 23:12
@guitarbeard
Copy link

Hopefully, this gets merged sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mperreux @guitarbeard