Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session storage to DevTools #1920

Draft
wants to merge 2 commits into
base: v1.x-2022-07
Choose a base branch
from

Conversation

cartogram
Copy link
Contributor

Description

Adds a session display to the DevTools for debugging the project's chosen session type.

Additional context


Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

import {Table} from './Table.js';

interface Props {
session: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not able to get a concrete type for this, then this should be unknown. We're trying to move away from any as it's not typesafe.

Makes me realize I should go update the eslint / typescript configs for this 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants