Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

299 mediumint unsigned fixed #300

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion dml_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func NewBinlogDMLEvents(table *TableSchema, ev *replication.BinlogEvent, pos, re
)
}
for i, col := range table.Columns {
if col.IsUnsigned {
if col.IsUnsigned && col.Type != schema.TYPE_MEDIUM_INT {
switch v := row[i].(type) {
case int64:
row[i] = uint64(v)
Expand All @@ -305,6 +305,11 @@ func NewBinlogDMLEvents(table *TableSchema, ev *replication.BinlogEvent, pos, re
case int:
row[i] = uint(v)
}
} else if col.IsUnsigned && col.Type == schema.TYPE_MEDIUM_INT {
if row[i] != nil {
val := row[i].(int32)
row[i] = NewUint24(val).Uint32()
}
}
}
}
Expand Down
27 changes: 27 additions & 0 deletions uint24.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// with the courtesy of this github file: https://github.com/Cryptkeeper/go-fseq/blob/v0.2.6/pkg/uint24/uint24.go
// used to convert a int32 to uint24 (mediumint)
package ghostferry

const MaxUint24 = 1<<24 - 1

func NewUint24(val int32) *Uint24 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would take a int32 to byte conversion, which in itself would require some code which you might not want to put in that location as well

var u = new(Uint24)
u.Set(val)
return u
}

type Uint24 [3]uint8

func (u *Uint24) Set(val int32) {
// panic since this is closer to how a compiler/runtime would treat an overflow compared to err returns
if val > MaxUint24 {
panic("cannot set Uint24 larger than uint24.MaxUint24")
}
(*u)[0] = uint8(val & 0xFF)
(*u)[1] = uint8((val >> 8) & 0xFF)
(*u)[2] = uint8((val >> 16) & 0xFF)
}

func (u Uint24) Uint32() uint32 {
return uint32(u[0]) | uint32(u[1])<<8 | uint32(u[2])<<16
}