Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camran Hansen Shopify Eng Assessment #306

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Camran Hansen Shopify Eng Assessment #306

wants to merge 12 commits into from

Commits on Jan 28, 2024

  1. Generate Article scaffold

    @camranhansen
    camranhansen committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    bf5830e View commit details
    Browse the repository at this point in the history

  2. Add not null constraints and default values to database

    @camranhansen
    camranhansen committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    951bab7 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. refactor tests to not use fixtures due to expectation conflict with t… 

    …est 'starts with no articles' in article_test.rb
    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8a4f343 View commit details
    Browse the repository at this point in the history

  2. formatting fix

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b8bba8e View commit details
    Browse the repository at this point in the history

  3. add validation to article model

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2b545c5 View commit details
    Browse the repository at this point in the history

  4. add search functionality to article model

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    df49a62 View commit details
    Browse the repository at this point in the history

  5. account for search term being nil

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ef0c2b1 View commit details
    Browse the repository at this point in the history

  6. add pagination with kaminari

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d6537de View commit details
    Browse the repository at this point in the history

  7. enable search functionality in view

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3256619 View commit details
    Browse the repository at this point in the history

  8. "Improve" UI

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7e29aaa View commit details
    Browse the repository at this point in the history

  9. update documentation

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f9b5dac View commit details
    Browse the repository at this point in the history

  10. Move article creation button to top of page

    @camranhansen
    camranhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3ed232a View commit details
    Browse the repository at this point in the history