Implement encyclopedia rails application #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes an unused CSS class from the application stylesheet * Removes an unused template variable from the articles controller * Adds endpoint documentation to the article controller's methods * Removes the use of HTML entities from the articles index view * Fixes indentation in the articles show view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the encyclopedia CRUD app, and satisfies the required tests. I made a few design decisions in the process of development which are worth highlighting, in case they need to be corrected:
Article.titleandArticle.authorare both of typestringinstead oftext. This means they're each limited to 255 characters each in some databases, but this limit won't exist in the current SQLite database since SQLite ignores LENGTH restrictions.Based on the tests in
test/models/article_test.rb, I decided to makeArticle.titleandArticle.contentmandatory fields (seeapp/models/article.rb). This may be an incorrect choice depending on the external requirements for this project, e.g., if users want to save articles before they think of a title for them.