[WIP] Add Pannable plugin #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @owen-m1, I had a general suggestion. Seems like one commit is containing too much of a code changes. Could it be broken down into smaller frequent commits, so that the history is much easier to follow and review by commits? Thanks. |
|
@dibosh I completely agree with you but I was following the PR guide which said to force-push to one commit. I don't like this either D: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements or fixes...
Adds a
Pannableplugin to Draggable, for panning around elements that have overflow in their parent container. Effectively making it a replacement for scrollbars.…
This PR closes the following issues...
#309
…
Does this PR require the Docs to be updated?
Yes
…
Does this PR require new tests?
Yes
…
This branch been tested on... (click all that apply / add new items)
Browsers: