Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated regional default locale codes to be default #3473

Merged
merged 1 commit into from
May 15, 2024

Conversation

lgunn4
Copy link
Contributor

@lgunn4 lgunn4 commented May 14, 2024

PR Summary:

Renamed regional locale keys to their default counterpart (e.g. ro-RO to ro).

Currently if a merchant adds a locale with a regional variant (ro-RO) as an alternate locale (ro), the default translations that we support out of the box does not include this locale code (we support ro not ro-RO... which is wrong)

In order to address this we are updating the root locale keys of the regional locales to their default variations.

Why are these changes introduced?

Work towards this issue: https://github.com/Shopify/store-localization/issues/4214

What approach did you take?

Renamed translation files and updated translation.yml

Other considerations

Will this impact the upgrade path for merchants ?

Visual impact on existing themes

N/A
Merchants using these locale codes as an alternate locale will now be able to see a translated storefront (out of the box translations)

Testing steps/scenarios

  • Step 1

Demo links

Store:
https://logan-development-test.myshopify.com/
Password: passwordpassword

Checklist

@lgunn4 lgunn4 changed the title renamed regional locales to default Updated regional locales to default May 14, 2024
@lgunn4 lgunn4 changed the title Updated regional locales to default Updated regional default locale codes to be default May 14, 2024
@lgunn4 lgunn4 marked this pull request as ready for review May 14, 2024 20:56
@dan-menard
Copy link
Member

Couple things we might need to check:

  • The translation-platform check failed, and says to reach out to a Slack channel for assistance because you're renaming locale files. Please do this :D otherwise we might have some problems with our next translations PR.
  • We should check the impact on apps here—I'll handle this, I know an internal app we can check first to get a kind of temperature check here.

@trishrempel
Copy link

trishrempel commented May 15, 2024

The translation-platform check failed, and says to reach out to a Slack channel for assistance because you're renaming locale files. Please do this :D otherwise we might have some problems with our next translations PR.

The PR is good to go from a Translation Platform perspective, and I cleared the failing check! 👍🏻

Copy link
Contributor

@tyleralsbury tyleralsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@lgunn4 lgunn4 merged commit a4e898d into main May 15, 2024
8 checks passed
@lgunn4 lgunn4 deleted the lgunn4/renamed-regional-locales-to-default branch May 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants