Updated regional default locale codes to be default #3473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Renamed regional locale keys to their default counterpart (e.g.
ro-RO
toro
).Currently if a merchant adds a locale with a regional variant (
ro-RO
) as an alternate locale (ro
), the default translations that we support out of the box does not include this locale code (we supportro
notro-RO
... which is wrong)In order to address this we are updating the root locale keys of the regional locales to their default variations.
Why are these changes introduced?
Work towards this issue: https://github.com/Shopify/store-localization/issues/4214
What approach did you take?
Renamed translation files and updated translation.yml
Other considerations
Will this impact the upgrade path for merchants ?
Visual impact on existing themes
N/A
Merchants using these locale codes as an alternate locale will now be able to see a translated storefront (out of the box translations)
Testing steps/scenarios
Demo links
Store:
https://logan-development-test.myshopify.com/
Password: passwordpassword
Checklist