Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix country drawer for small choices #3394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

francoispeyret
Copy link

PR Summary:

QuickFix to next issue.

Issue reference

The country selector's height with not many countries on it feels a bit overwhelming on mobile in the menu drawer. (Video reference)

My fix :

image

Why are these changes introduced?

Fixes #3252 .

What approach did you take?

Minimum code modification for fix the issue.

Visual impact on existing themes

If the country's choice is small the drawer was small too and the height was limited at 80% of screen's height.

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale selectors: Optimize for when fewer options available on the list
2 participants