Polish base typography #3331
Open
Polish base typography #3331
+210
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Tidy up typography to remove transparency and tighten up heading sizes and line spacing to be more consistent and cleaner.
Why are these changes introduced?
The typography in Dawn is a little all over the place and is particularly noticeable with heading sizes and line spacing as well as the transparency on the logo if using text, product cards, and rich text paragraphs.
What approach did you take?
Attempted to make bare minimum changes; however, because the underlying typography stack is so complex, it’s hard to do.
Visual impact on existing themes
it should be minimal but it will impact the typography stack.
Demo links