Move featured collection view all inline #3323
Open
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed from shop: Lucid Dawn
…inline Committed from shop: Lucid Dawn
This reverts commit 87fd334.
…thub.com/lucidcommerceco/dawn into move-featured-collection-view-all-inline
|
@tyleralsbury, any idea why my PR’s are being flagged with |
It looks like you haven't signed the CLA. In the error message you can see: If you follow those steps, it should pass. |
|
@tyleralsbury, the weird thing is that I have signed the CLA. Just to be sure, I double-checked and when I attempt to sign, it says I have already signed 🤷♂️ |
|
I have signed the CLA! |
|
Hm, weird. We'll need to take a look. Maybe something is acting up in how it's configured (suddenly). |
|
I also signed the cla, but my recent pr still says I didn't. |
|
Adding a toggle to move the slider arrows to be inline with the view all button would also be handy, given that's where most stores position it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
When "View all" if collection has more products than shown is enabled in the Featured Collection section, it currently shows below the grid of products. With headings and most elements left-aligned in Dawn, this usually feels out of place and is visually jarring. Depending on the theme settings, it also sometimes has no margin between the grid and the buttons.
Why are these changes introduced?
I believe it is more intuitive and user-friendly to have the “View All” button aligned with the heading. If no heading exists, don’t show.
What approach did you take?
Bare minimum re-arranging of code with a few CSS tweaks.
Visual impact on existing themes
Demo links
Checklist