Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collage image link support #3320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

galenking
Copy link

PR Summary:

Add support for links in the collage section to enable better engagement and storytelling.

Why are these changes introduced?

The collage section is great for storytelling but, without links, images are not clickable so there is no possible engagement. Being able to specify a link enables merchants to make images clickable.

Visual impact on existing themes

Images become clickable and add the hover effect if a link is specified.

Checklist

@@ -559,6 +559,9 @@
"settings": {
"image": {
"label": "Image"
},
"link": {
"label": "Link"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Link for key sections.collage.blocks.image.settings.link.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@galenking
Copy link
Author

Replaces #3167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant