Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection list custom title and image #3319

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

galenking
Copy link

PR Summary:

Why are these changes introduced?

  1. The collection list section uses the title and image of the collection
  2. This can be problematic when rebuilding a site using Dawn as existing collections may have images and titles that don’t fit the new design but making changes to the collection would impact the live theme
  3. Often, merchants need to use different titles and/or images in collection lists than what is set at the collection level
  4. Enables support for collection metafields for titles and/or images in collection lists

What approach did you take?

  1. Low-code/minimal changes with graceful fallbacks

Visual impact on existing themes

  1. There is no visual change on the frontend
  2. Adds two block-level theme settings

Checklist

@@ -581,6 +581,12 @@
"settings": {
"collection": {
"label": "Collection"
},
"title": {
"label": "Custom Title"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Custom Title for key sections.collage.blocks.collection.settings.title.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"label": "Custom Title"
},
"image": {
"label": "Custom Image"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Custom Image for key sections.collage.blocks.collection.settings.image.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@@ -653,6 +659,12 @@
"settings": {
"collection": {
"label": "Collection"
},
"title": {
"label": "Custom Title"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Custom Title for key sections.collection-list.blocks.featured_collection.settings.title.label is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@galenking
Copy link
Author

@tyleralsbury, as I mentioned in #3164, I messed up the original PR, and this now replaces it. My apologies.

@tyleralsbury
Copy link
Contributor

Hey, no problem. Thanks Galen! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants