-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection list custom title and image #3319
base: main
Are you sure you want to change the base?
Collection list custom title and image #3319
Conversation
@@ -581,6 +581,12 @@ | |||
"settings": { | |||
"collection": { | |||
"label": "Collection" | |||
}, | |||
"title": { | |||
"label": "Custom Title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Custom Title
for keysections.collage.blocks.collection.settings.title.label
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
"label": "Custom Title" | ||
}, | ||
"image": { | ||
"label": "Custom Image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Custom Image
for keysections.collage.blocks.collection.settings.image.label
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
@@ -653,6 +659,12 @@ | |||
"settings": { | |||
"collection": { | |||
"label": "Collection" | |||
}, | |||
"title": { | |||
"label": "Custom Title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Custom Title
for keysections.collection-list.blocks.featured_collection.settings.title.label
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
@tyleralsbury, as I mentioned in #3164, I messed up the original PR, and this now replaces it. My apologies. |
Hey, no problem. Thanks Galen! 👍 |
PR Summary:
Why are these changes introduced?
What approach did you take?
Visual impact on existing themes
Checklist