Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Improved the Dashing gh-page navigation #384

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

juhamust
Copy link

I always struggle to find the wanted information from Dashing pages - especially the widgets. This pull request tries to improve the structure/situation.

  • Using same titles as in navigation
  • Moved demo into buttons
  • Listing the widgets (finding built-in and 3rd party widgets was hard to find)

- Using same titles as in navigation
- Moved demo into buttons
- Listing the widgets (finding built-in and 3rd party wigets was hard to find)
@@ -214,6 +214,23 @@ <h3 class="section-title">Getting Data Into Your Widgets</h3>

<script src="https://gist.github.com/davefp/6112780.js?file=curl2.sh"></script>

<h4>Widgets</h4>

<p>Dashing comes with few re-usable widgets (reminder: <i>data-view="WidgetName"</i> in dashboard defines the used widget):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this should read:
Dashing comes with a few re-usable widgets, which can be used as indicated above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I surely can update the PR - assumed no one was interested merging it (as this is almost year old)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am going through all the old PRs and trying to triage it a bit for the maintainer(s).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I wasn't implying you had to be the one to make the updates -- just that these are the updates I recommend. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm pretty much fine with any additional change (while still holding the original idea of three items mentioned in PR). So go ahead, you have my blessing 👍

@terraboops
Copy link
Contributor

The changes can be viewed here: http://juhamust.github.io/dashing/

Overall, I like these changes. My only gripe is with the Widgets section that was added to the bottom of #data -- I've made a note in the source code.

My suggestion is:

  • Add a page which lists the widgets in detail, or perhaps create demos of them in the demo app
  • Remove the <ul> -- it looks unfinished to me as it is
  • Link to the page that lists each widget with details instead

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants