Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Get the view path of a widget on IE #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bielfrontera
Copy link

Replace constructor.name with a new function called getName that works on Internet Explorer.
This new function is based on this workaround to support Function.name: http://matt.scharley.me/2012/03/09/monkey-patch-name-ie.html

Combined with PR #310, the library works fine on IE.

Disclaimer: I do not use Internet Explorer! However, I developed a TV panel using your library, and now we have to support IE...

Replace constructor.name with a new function called getName that works on Internet Explorer.
This new function is based on this workaround to support Function.name: http://matt.scharley.me/2012/03/09/monkey-patch-name-ie.html

Combined with PR Shopify#310, the library works fine on IE.

Disclaimer: I do not use Internet Explorer! However, I developed a TV panel using your library, and now we have to support IE...
@liquiddc
Copy link

Thanks for this. I note that this same fix is used in the dashing.coffee in the node.js port of dashing, which works much better with IE.

@rafaelescrich
Copy link

Hello,

i'm trying to use dashing with the fixes for the IE and i'm not getting nothing. I tried in IE9, IE10 and IE11. I even cloned the repo of bielfrontera and liquidcc but nothing. Can you help?

@StephenTerry
Copy link

Rafael,

Have you installed node.js and the event-source code? It wasn't working for me until I installed those things.

@liquiddc
Copy link

Hi Rafael, Sorry for the delayed response. I moved over to dashing-js, a
node.js clone of dashing, and found that the IE fixes have been more
actively taken on and it works fine in IE11. I have also noted that in a
corporate environment, the corporate network proxy will introduce issues
that you just won't see in a less restricted environment. Cheers, Dan

On Thu, Jun 12, 2014 at 12:34 AM, Rafael Escrich notifications@github.com
wrote:

Hello,

i'm trying to use dashing with the fixes for the IE and i'm not getting
nothing. I tried in IE9, IE10 and IE11. I even cloned the repo of
bielfrontera and liquidcc but nothing. Can you help?


Reply to this email directly or view it on GitHub
#322 (comment).

@terraboops
Copy link
Contributor

Based on @rafaelescrich's comment, can someone confirm if this PR works in IE and if so, what versions?

Otherwise, no breaking changes and this seems like a desirable feature. Even if IE is lame.

@terraboops
Copy link
Contributor

Just found #310 -- seems like that PR is a better candidate as it includes these fixes as well as other changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants