Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Add error handling when development theme role gets mismatched #3802

Closed
wants to merge 2 commits into from

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Apr 27, 2024

WHY are these changes introduced?

Following up on

I want to open this PR as a forum for discussion

  • Do we even want to add this code since its only purpose is to help reset ephemeral data? (The local data lasts 7 days AFAIK) Docs
  • Currently, I'm only adding this guard to findAndCreate which means that

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

@jamesmengo jamesmengo changed the base branch from main to jmeng/devthemes April 27, 2024 00:58
@jamesmengo jamesmengo requested review from karreiro and a team April 27, 2024 00:59
Copy link
Contributor

github-actions bot commented Apr 27, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.81% 6947/9674
🟡 Branches 68.78% 3423/4977
🟡 Functions 71.24% 1863/2615
🟡 Lines 73.11% 6547/8955

Test suite run success

1637 tests passing in 764 suites.

Report generated by 🧪jest coverage report action from b068f0a

@jamesmengo jamesmengo changed the title Jmeng/devthemeabort [Theme] Add error handling when development theme role gets mismatched Apr 27, 2024
@jamesmengo
Copy link
Contributor Author

Changing the local key instead in #3798

@jamesmengo jamesmengo closed this Apr 29, 2024
@jamesmengo jamesmengo deleted the jmeng/devthemeabort branch May 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant