Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added is_marketplace, use_shopify_tax and marketplace_registrations t… #3758

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mchemanishop
Copy link

@mchemanishop mchemanishop commented Apr 19, 2024

Relies on

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@mchemanishop mchemanishop force-pushed the mchemani/add-new-fiels-to-tax-calculation-extension branch from a30b049 to b127bf1 Compare April 19, 2024 17:14
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.98% (-0.01% 🔻)
6976/9691
🟡 Branches
69% (+0.04% 🔼)
3441/4987
🟡 Functions 71.21% 1855/2605
🟡 Lines
73.29% (-0.01% 🔻)
6580/8978
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / utilities.ts
97.44% (-0.06% 🔻)
84.62% (+4.62% 🔼)
80%
97.44% (-0.06% 🔻)
🟡
... / generate.ts
66.13% (-1.06% 🔻)
58.54% (+2.72% 🔼)
50%
70.18% (-1.01% 🔻)

Test suite run success

1656 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from b127bf1

@mchemanishop mchemanishop marked this pull request as draft April 22, 2024 17:25
@mchemanishop mchemanishop changed the title Added is_marketplace, use_shopify_tax and marketplace_registrations t… [WIP] Added is_marketplace, use_shopify_tax and marketplace_registrations t… Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant