Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @oclif/core to 3.26.2 #3756

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update @oclif/core to 3.26.2 #3756

wants to merge 3 commits into from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Apr 19, 2024

WHY are these changes introduced?

We wanted to remove the hardcoded resolution for a specific version of oclif, no need to do it if we keep the dependencies correctly updated.

Fixes #3506

WHAT is this pull request doing?

  • Update @oclif/core to version 3.26.2
  • Update oclif plugins to their latests versions (which also use core 3.26.2)
  • Regenerate manifests/README

How to test your changes?

Nothing to test, if CI passes, everything should be OK

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Apr 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 71.77% 6904/9620
🟡 Branches 68.72% 3401/4949
🟡 Functions 71.14% 1849/2599
🟡 Lines 73.08% 6506/8903

Test suite run success

1630 tests passing in 761 suites.

Report generated by 🧪jest coverage report action from 2de0f6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @oclif/core dependency is duplicated when using NPM
1 participant